Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide empty tabs on address page #1045

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

brancoder
Copy link
Collaborator

Description of change

Hide empty tabs on address page
fixes #950

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we might want to improve this by adding a loading skeleton or something, but for now this is good 👍🏼 thanks!

@begonaalvarezd begonaalvarezd merged commit 4e6f769 into main Feb 1, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/hide-empty-tabs branch February 1, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement UX]: Hide or collapse tabs that are empty on the Alias Output page
3 participants